lkml.org 
[lkml]   [2022]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tracing/histograms: Simplify create_hist_fields()
On Thu, 30 Jun 2022 09:31:52 +0800
Zheng Yejian <zhengyejian1@huawei.com> wrote:

> diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
> index 2784951e0fc8..832c4ccf41ab 100644
> --- a/kernel/trace/trace_events_hist.c
> +++ b/kernel/trace/trace_events_hist.c
> @@ -4454,7 +4454,7 @@ static int create_hist_fields(struct hist_trigger_data *hist_data,
>
> ret = parse_var_defs(hist_data);
> if (ret)
> - goto out;
> + return ret;

This is a functional change.

>
> ret = create_val_fields(hist_data, file);
> if (ret)
> @@ -4465,8 +4465,7 @@ static int create_hist_fields(struct hist_trigger_data *hist_data,
> goto out;
>
> ret = create_key_fields(hist_data, file);
> - if (ret)
> - goto out;
> +
> out:

This is not a functional change ;-)

If you just had the latter, then it would have been OK to state "No
functional changes".

-- Steve

> free_var_defs(hist_data);
>

\
 
 \ /
  Last update: 2022-07-12 19:53    [W:0.051 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site