lkml.org 
[lkml]   [2022]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC v2 24/39] PCI/sysfs: make I/O resource depend on HAS_IOPORT
    On Fri, Apr 29, 2022 at 03:50:39PM +0200, Niklas Schnelle wrote:
    > Exporting I/O resources only makes sense if legacy I/O spaces are
    > supported so conditionally add them only if HAS_IOPORT is set.

    Same comments as for 23/39.

    Once addressed,

    Acked-by: Bjorn Helgaas <bhelgaas@google.com>

    One more comment below.

    > Co-developed-by: Arnd Bergmann <arnd@kernel.org>
    > Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
    > ---
    > drivers/pci/pci-sysfs.c | 16 ++++++++++++++++
    > 1 file changed, 16 insertions(+)
    >
    > diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
    > index c263ffc5884a..eda258fa4981 100644
    > --- a/drivers/pci/pci-sysfs.c
    > +++ b/drivers/pci/pci-sysfs.c
    > @@ -1091,6 +1091,7 @@ static int pci_mmap_resource_wc(struct file *filp, struct kobject *kobj,
    > return pci_mmap_resource(kobj, attr, vma, 1);
    > }
    >
    > +#ifdef CONFIG_HAS_IOPORT
    > static ssize_t pci_resource_io(struct file *filp, struct kobject *kobj,
    > struct bin_attribute *attr, char *buf,
    > loff_t off, size_t count, bool write)
    > @@ -1149,6 +1150,21 @@ static ssize_t pci_write_resource_io(struct file *filp, struct kobject *kobj,
    >
    > return pci_resource_io(filp, kobj, attr, buf, off, count, true);
    > }
    > +#else

    I would probably move the #ifdefs inside the function to avoid
    repeating the function signature.

    > +static ssize_t pci_read_resource_io(struct file *filp, struct kobject *kobj,
    > + struct bin_attribute *attr, char *buf,
    > + loff_t off, size_t count)
    > +{
    > + return -ENXIO;
    > +}
    > +
    > +static ssize_t pci_write_resource_io(struct file *filp, struct kobject *kobj,
    > + struct bin_attribute *attr, char *buf,
    > + loff_t off, size_t count)
    > +{
    > + return -ENXIO;
    > +}
    > +#endif
    >
    > /**
    > * pci_remove_resource_files - cleanup resource files
    > --
    > 2.32.0
    >

    \
     
     \ /
      Last update: 2022-06-08 20:32    [W:7.347 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site