lkml.org 
[lkml]   [2022]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC v2 23/39] PCI: make quirk using inw() depend on HAS_IOPORT
    In subject, s/make quirk/Make quirk/

    On Fri, Apr 29, 2022 at 03:50:37PM +0200, Niklas Schnelle wrote:
    > In the future inw() and friends will not be compiled on architectures
    > without I/O port support.

    Commit log should say what the patch does. Even if it's in the
    subject, make the commit log stand alone.

    With the above,

    Acked-by: Bjorn Helgaas <bhelgaas@google.com>

    > Co-developed-by: Arnd Bergmann <arnd@kernel.org>
    > Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
    > ---
    > drivers/pci/quirks.c | 2 ++
    > 1 file changed, 2 insertions(+)
    >
    > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
    > index da829274fc66..27db2810f034 100644
    > --- a/drivers/pci/quirks.c
    > +++ b/drivers/pci/quirks.c
    > @@ -265,6 +265,7 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NEC, PCI_DEVICE_ID_NEC_CBUS_1, quirk_isa_d
    > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NEC, PCI_DEVICE_ID_NEC_CBUS_2, quirk_isa_dma_hangs);
    > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NEC, PCI_DEVICE_ID_NEC_CBUS_3, quirk_isa_dma_hangs);
    >
    > +#ifdef CONFIG_HAS_IOPORT
    > /*
    > * Intel NM10 "TigerPoint" LPC PM1a_STS.BM_STS must be clear
    > * for some HT machines to use C4 w/o hanging.
    > @@ -284,6 +285,7 @@ static void quirk_tigerpoint_bm_sts(struct pci_dev *dev)
    > }
    > }
    > DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_TGP_LPC, quirk_tigerpoint_bm_sts);
    > +#endif
    >
    > /* Chipsets where PCI->PCI transfers vanish or hang */
    > static void quirk_nopcipci(struct pci_dev *dev)
    > --
    > 2.32.0
    >

    \
     
     \ /
      Last update: 2022-06-08 20:31    [W:6.212 / U:0.564 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site