lkml.org 
[lkml]   [2022]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 2/9] usb: typec: Add retimer handle to port
Hi,

On Wed, Jun 29, 2022 at 11:32:20PM +0000, Prashant Malani wrote:
> Similar to mux and orientation switch, add a handle for registered
> retimer to the port, so that it has handles to the various switches
> connected to it.
>
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
> ---
> drivers/usb/typec/class.c | 8 ++++++++
> drivers/usb/typec/class.h | 1 +
> 2 files changed, 9 insertions(+)
>
> diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> index 2fa0b3718d23..2bc5fbdb25dd 100644
> --- a/drivers/usb/typec/class.c
> +++ b/drivers/usb/typec/class.c
> @@ -12,6 +12,7 @@
> #include <linux/slab.h>
> #include <linux/usb/pd_vdo.h>
> #include <linux/usb/typec_mux.h>
> +#include <linux/usb/typec_retimer.h>
>
> #include "bus.h"
> #include "class.h"
> @@ -2249,6 +2250,13 @@ struct typec_port *typec_register_port(struct device *parent,
> return ERR_PTR(ret);
> }
>
> + port->retimer = typec_retimer_get(&port->dev);
> + if (IS_ERR(port->retimer)) {
> + ret = PTR_ERR(port->retimer);
> + put_device(&port->dev);
> + return ERR_PTR(ret);
> + }
> +
> ret = device_add(&port->dev);
> if (ret) {
> dev_err(parent, "failed to register port (%d)\n", ret);

I think you need to release the reference with typec_retimer_put() in
typec_release().

I guess we can look handle this later, but there can actually be two
onboard retimers for each connector.

thanks,

> diff --git a/drivers/usb/typec/class.h b/drivers/usb/typec/class.h
> index 1bb1da124109..97520406929e 100644
> --- a/drivers/usb/typec/class.h
> +++ b/drivers/usb/typec/class.h
> @@ -55,6 +55,7 @@ struct typec_port {
> enum typec_orientation orientation;
> struct typec_switch *sw;
> struct typec_mux *mux;
> + struct typec_retimer *retimer;
>
> const struct typec_capability *cap;
> const struct typec_operations *ops;

--
heikki

\
 
 \ /
  Last update: 2022-06-30 10:28    [W:0.071 / U:0.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site