lkml.org 
[lkml]   [2022]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/9] mm/mshare: pre-populate msharefs with information file
On Wed, Jun 29, 2022 at 04:53:53PM -0600, Khalid Aziz wrote:

> +static void
> +mshare_evict_inode(struct inode *inode)
> +{
> + clear_inode(inode);
> +}

Again, what for? And while we are at it, shouldn't you evict the
pages when inode gets freed and ->i_data along with it?
IOW, aren't you missing
truncate_inode_pages_final(&inode->i_data);
That, or just leave ->evict_inode NULL...

\
 
 \ /
  Last update: 2022-07-01 01:03    [W:0.363 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site