lkml.org 
[lkml]   [2022]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] ALSA: hda/ca0132: fix potential memory leak in dspxfr_image()
Date
dspxfr_image() allocates DSP ports for the download stream with
dsp_allocate_ports_format(). When some error occurs, the allocated
DSP ports are not released, which will lead to a memory leak.

We can fix it by releasing DSP ports with dsp_free_ports() if some
error occurs.

Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
---
sound/pci/hda/patch_ca0132.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
index 208933792787..6b8f45e14075 100644
--- a/sound/pci/hda/patch_ca0132.c
+++ b/sound/pci/hda/patch_ca0132.c
@@ -3455,6 +3455,7 @@ static int dspxfr_image(struct hda_codec *codec,
&port_map_mask);
if (status < 0) {
codec_dbg(codec, "alloc ports fail\n");
+ dsp_free_ports(codec);
goto exit;
}

@@ -3463,6 +3464,7 @@ static int dspxfr_image(struct hda_codec *codec,
WIDGET_CHIP_CTRL, stream_id, 0, &response);
if (status < 0) {
codec_dbg(codec, "set stream chan fail\n");
+ dsp_free_ports(codec);
goto exit;
}

@@ -3470,6 +3472,7 @@ static int dspxfr_image(struct hda_codec *codec,
if (!is_valid(fls_data)) {
codec_dbg(codec, "FLS check fail\n");
status = -EINVAL;
+ dsp_free_ports(codec);
goto exit;
}
status = dspxfr_one_seg(codec, fls_data, reloc,
--
2.25.1
\
 
 \ /
  Last update: 2022-06-29 19:19    [W:0.116 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site