[lkml]   [2022]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2] ASoC: codecs: wsa883x: add control, dapm widgets and map
On Wed, Jun 29, 2022 at 03:58:31PM +0100, Srinivas Kandagatla wrote:

> +static const char * const wsa_dev_mode_text[] = {
> + "speaker", "receiver", "ultrasound"

Idiomatically these would be capitalised ("Speaker" and so on). Sorry,
didn't notice on v1. Otherwise this looks good.
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2022-06-29 17:03    [W:0.030 / U:1.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site