[lkml]   [2022]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH v6 0/4] soc/arm64: qcom: Add initial version of bwmon

Changes since v5
1. Rename compatible (and files) to qcom,msm8998-llcc-bwmon as Rajendra suggested.
Keep the reviews/acks as the change is not significant.
2. Update comment in DTS, update description in bindings and in Kconfig.

Changes since v4
1. Patch #1 (binding): Use qcom,msm8998-cpu-bwmon fallback compatible, only one
interconnect. Rename to qcom,msm8998-cpu-bwmon.yaml. This reflects
discussion with Bjorn, about the proper fallback compatible. Driver was
tested only on SDM845, so only that one compatible is actually implemented.
Keep the reviews/acks as the change is not significant.
2. Patch #4 (DTS): Use qcom,msm8998-cpu-bwmon fallback compatible, only one
interconnect, use the LLCC bandwidth in OPP.

remove unused irq_enable (kbuild robot);
Changes since v3
1. Patch #2 (bwmon): remove unused irq_enable (kbuild robot);
split bwmon_clear() into clearing counters and interrupts, so bwmon_start()
does not clear the counters twice.

Changes since v2
1. Spent a lot of time on benchmarking and learning the BWMON behavior.
2. Drop PM/OPP patch - applied.
3. Patch #1: drop opp-avg-kBps.
4. Patch #2: Add several comments explaining pieces of code and BWMON, extend
commit msg with measurements, extend help message, add new #defines to document
some magic values, reorder bwmon clear/disable/enable operations to match
downstream source and document this with comments, fix unit count from 1 MB
to 65 kB.
5. Patch #4: drop opp-avg-kBps.
6. Add accumulated Rb tags.

Changes since v1
1. Add defconfig change.
2. Fix missing semicolon in MODULE_AUTHOR.
3. Add original downstream (msm-4.9 tree) copyrights to the driver.

BWMON is a data bandwidth monitor providing throughput/bandwidth over certain
interconnect links in a SoC. It might be used to gather current bus usage and
vote for interconnect bandwidth, thus adjusting the bus speed based on actual

The work is built on top of Thara Gopinath's patches with several cleanups,
changes and simplifications.

Cc: Rajendra Nayak <>

Best regards,

Krzysztof Kozlowski (4):
dt-bindings: interconnect: qcom,msm8998-cpu-bwmon: add BWMON device
soc: qcom: icc-bwmon: Add bandwidth monitoring driver
arm64: defconfig: enable Qualcomm Bandwidth Monitor
arm64: dts: qcom: sdm845: Add CPU BWMON

.../interconnect/qcom,msm8998-llcc-bwmon.yaml | 85 ++++
arch/arm64/boot/dts/qcom/sdm845.dtsi | 37 ++
arch/arm64/configs/defconfig | 1 +
drivers/soc/qcom/Kconfig | 15 +
drivers/soc/qcom/Makefile | 1 +
drivers/soc/qcom/icc-bwmon.c | 421 ++++++++++++++++++
7 files changed, 567 insertions(+)
create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,msm8998-llcc-bwmon.yaml
create mode 100644 drivers/soc/qcom/icc-bwmon.c


 \ /
  Last update: 2022-06-29 16:04    [W:0.066 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site