lkml.org 
[lkml]   [2022]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Input: exc3000 - Fix return value check of wait_for_completion_timeout
On Mon, Apr 11, 2022 at 10:58:23AM +0000, Miaoqian Lin wrote:
> wait_for_completion_timeout() returns unsigned long not int.
> It returns 0 if timed out, and positive if completed.
> The check for <= 0 is ambiguous and should be == 0 here
> indicating timeout which is the only error case.
>
> Fixes: 102feb1ddfd0 ("Input: exc3000 - factor out vendor data request")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>

Applied, thank you.

--
Dmitry

\
 
 \ /
  Last update: 2022-06-29 07:48    [W:0.086 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site