lkml.org 
[lkml]   [2022]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/4] dt-bindings: misc: tmr-inject: Add device-tree binding for TMR Inject
From


On 6/29/22 12:08, Krzysztof Kozlowski wrote:
> On 28/06/2022 07:43, Appana Durga Kedareswara rao wrote:
>> This commit adds documentation for Triple Modular Redundancy (TMR)
>
> No "This commit"
>
> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
>
>> Inject IP.
>>
>> Signed-off-by: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>
>> ---
>> .../bindings/misc/xlnx,tmr-inject.yaml | 47 +++++++++++++++++++
>> 1 file changed, 47 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/misc/xlnx,tmr-inject.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/misc/xlnx,tmr-inject.yaml b/Documentation/devicetree/bindings/misc/xlnx,tmr-inject.yaml
>> new file mode 100644
>> index 000000000000..4daf9539000b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/misc/xlnx,tmr-inject.yaml
>> @@ -0,0 +1,47 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/misc/xlnx,tmr-inject.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Xilinx TMR Inject Device Tree Bindings
>
> Same comments.
>
>> +
>> +maintainers:
>> + - Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>
>> +
>> +description: |
>> + The Triple Modular Redundancy(TMR) Inject core provides functional fault
>> + injection by changing selected MicroBlaze instructions, which provides the
>> + possibility to verify that the TMR subsystem error detection and fault
>> + recovery logic is working properly.
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - xlnx,tmr-inject-1.0
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + xlnx,magic:
>> + minimum: 0
>> + maximum: 255
>> + description: |
>> + Magic number used when injecting faults. The fault inject write data least
>> + significant byte (bits 7:0) must match this number to have any effect.
>
> And why exactly register value is a property of DT?
>
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - xlnx,magic
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + tmr-inject@44a30000 {
>
> fault-inject?

no problem with it but I think it would be good to extend 2.2.2 chapter in
devicetree specification with these generic names.

Thanks,
Michal

\
 
 \ /
  Last update: 2022-06-29 13:30    [W:0.121 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site