lkml.org 
[lkml]   [2022]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v12 2/3] dt-bindings: usb: Add analogix anx7411 PD binding
From
On 28/06/2022 06:48, Xin Ji wrote:
> Add analogix PD chip anx7411 device binding
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Xin Ji <xji@analogixsemi.com>
> ---
> .../bindings/usb/analogix,anx7411.yaml | 76 +++++++++++++++++++
> 1 file changed, 76 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/analogix,anx7411.yaml
>
> diff --git a/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml b/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml
> new file mode 100644
> index 000000000000..c5c6d5a9dc17
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml
> @@ -0,0 +1,76 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/usb/analogix,anx7411.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"

Drop the quotes from both places.

> +
> +title: Analogix ANX7411 Type-C controller bindings
> +
> +maintainers:
> + - Xin Ji <xji@analogixsemi.com>
> +
> +properties:
> + compatible:
> + enum:
> + - analogix,anx7411
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + connector:
> + type: object
> +
> + allOf:
> + - $ref: ../connector/usb-connector.yaml

additionalProperties: false
(on the level of allOf)

> +
> + properties:
> + compatible:
> + const: usb-c-connector
> +
> + power-role: true
> +
> + data-role: true
> +
> + try-power-role: true
> +
> + required:
> + - compatible
> +
> +required:
> + - compatible
> + - reg
> + - connector
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c1 {

"i2c"

> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + typec: anx7411@2C {

generic node name, so maybe usb-typec?

If fixed, keep Rob's Rb comment.

> + compatible = "analogix,anx7411";
> + reg = <0x2C>;
> + interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
> + interrupt-parent = <&gpio0>;
> +
> + typec_con: connector {
> + compatible = "usb-c-connector";
> + power-role = "dual";
> + data-role = "dual";
> + try-power-role = "source";
> +
> + port {

I think usb-c-connector requires "ports" node, doesn't it?

> + typec_con_ep: endpoint {
> + remote-endpoint = <&usbotg_hs_ep>;
> + };
> + };
> + };
> + };
> + };
> +...


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-06-29 12:14    [W:1.364 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site