lkml.org 
[lkml]   [2022]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v1 3/3] gpio: adp5588: sort header inclusion alphabetically
Date
Hi Andy,

> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> Sent: Wednesday, June 29, 2022 12:00 PM
> To: Hennerich, Michael <Michael.Hennerich@analog.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; linux-
> gpio@vger.kernel.org; linux-kernel@vger.kernel.org; Sa, Nuno
> <Nuno.Sa@analog.com>; Linus Walleij <linus.walleij@linaro.org>;
> Bartosz Golaszewski <brgl@bgdev.pl>
> Subject: Re: [PATCH v1 3/3] gpio: adp5588: sort header inclusion
> alphabetically
>
> [External]
>
> On Wed, Jun 29, 2022 at 10:50 AM Hennerich, Michael
> <Michael.Hennerich@analog.com> wrote:
> >
> >
> >
> > > -----Original Message-----
> > > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > Sent: Dienstag, 28. Juni 2022 21:39
> > > To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>;
> linux-
> > > gpio@vger.kernel.org; linux-kernel@vger.kernel.org
> > > Cc: Hennerich, Michael <Michael.Hennerich@analog.com>; Linus
> Walleij
> > > <linus.walleij@linaro.org>; Bartosz Golaszewski <brgl@bgdev.pl>
> > > Subject: [PATCH v1 3/3] gpio: adp5588: sort header inclusion
> alphabetically
> > >
> > > Sort header inclusion alphabetically.
> >
> > Thanks for the patches, they look good.
> > However, Nuno is currently working on getting the irqchip support
> into the
> > adp5588 input driver. In his patch series this driver is going away.
> >
> > https://urldefense.com/v3/__https://lore.kernel.org/linux-
> input/YpMCh1Xje*jsny8j@google.com/__;Kw!!A3Ni8CS0y2Y!_Cb1uAs
> D-
> Z6iz_zSDfrd5Va6zLmdoxjv1vLYWQGHDOqYniaXVVHl3Ou2lOUQIjwhSN
> Ku2aZkYrOb8xMi2cZtfmsv$
>
> While that work is ongoing, and most likely won't make v5.20-rc1, for
> the v5.20-rc1 I think my patches are good to go to avoid a bad (or
> rather very old) example on how to do GPIO drivers. What do you
> think?
>

Just as note, If nothing unexpected happens, I'm planning in sending this
out today. If you still think this makes sense, fine by me. It's a very minimal
change that won't give much pain to deal with...

- Nuno Sá
\
 
 \ /
  Last update: 2022-06-29 12:12    [W:0.063 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site