lkml.org 
[lkml]   [2022]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] staging: Thunderbolt: ctl.c: Fixed comment coding style issues
On Sat, Jun 25, 2022 at 02:37:54AM -0700, Joe Perches wrote:
[]
>
> I'd indent this only 1 level and put it before the call
> (and fix the loose/lose typo)
>
> {
> /* We ignore failures during stop.
> * All rx packets are referenced from ctl->rx_packets,
> * so we do not lose them.
> */
> tb_ring_rx(pkg->ctl->rx, &pkg->frame);
> }
>

Fair enough. Not sure on how to proceed, as these were my
first patches ever sent, and I don't want to make anyone
work more than the strictly necessary.

- Should I submit an additional patch intended to be applied
on top of 3/3?
- Should I sumbit a whole new 3/3, addressing the whole comment
issues all at once?
- Should I just wait on the outcome and proceed from there?

Advice would be appreciated.

Anyway, I will be sending some patches over other files for
the time being, paying more attention to the details.

Thanks,
~Gabriel

\
 
 \ /
  Last update: 2022-06-29 08:55    [W:0.073 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site