lkml.org 
[lkml]   [2022]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 18/22] mips/pic32/pic32mzda: Fix refcount leak bugs
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit eb9e9bc4fa5fb489c92ec588b3fb35f042ba6d86 ]

    of_find_matching_node(), of_find_compatible_node() and
    of_find_node_by_path() will return node pointers with refcout
    incremented. We should call of_node_put() when they are not
    used anymore.

    Signed-off-by: Liang He <windhl@126.com>
    Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/mips/pic32/pic32mzda/init.c | 7 ++++++-
    arch/mips/pic32/pic32mzda/time.c | 3 +++
    2 files changed, 9 insertions(+), 1 deletion(-)

    diff --git a/arch/mips/pic32/pic32mzda/init.c b/arch/mips/pic32/pic32mzda/init.c
    index 406c6c5cec29..f8985d4573e6 100644
    --- a/arch/mips/pic32/pic32mzda/init.c
    +++ b/arch/mips/pic32/pic32mzda/init.c
    @@ -131,13 +131,18 @@ static int __init pic32_of_prepare_platform_data(struct of_dev_auxdata *lookup)
    np = of_find_compatible_node(NULL, NULL, lookup->compatible);
    if (np) {
    lookup->name = (char *)np->name;
    - if (lookup->phys_addr)
    + if (lookup->phys_addr) {
    + of_node_put(np);
    continue;
    + }
    if (!of_address_to_resource(np, 0, &res))
    lookup->phys_addr = res.start;
    + of_node_put(np);
    }
    }

    + of_node_put(root);
    +
    return 0;
    }

    diff --git a/arch/mips/pic32/pic32mzda/time.c b/arch/mips/pic32/pic32mzda/time.c
    index 1894e50939b5..04879b85aac9 100644
    --- a/arch/mips/pic32/pic32mzda/time.c
    +++ b/arch/mips/pic32/pic32mzda/time.c
    @@ -40,6 +40,9 @@ static unsigned int pic32_xlate_core_timer_irq(void)
    goto default_map;

    irq = irq_of_parse_and_map(node, 0);
    +
    + of_node_put(node);
    +
    if (!irq)
    goto default_map;

    --
    2.35.1
    \
     
     \ /
      Last update: 2022-06-28 04:35    [W:15.221 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site