lkml.org 
[lkml]   [2022]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 02/19] cacheinfo: Use of_cpu_device_node_get instead cpu_dev->of_node
    Date
    The of_cpu_device_node_get takes care of fetching the CPU'd device node
    either from cached cpu_dev->of_node if cpu_dev is initialised or uses
    of_get_cpu_node to parse and fetch node if cpu_dev isn't available yet.

    Just use of_cpu_device_node_get instead of getting the cpu device first
    and then using cpu_dev->of_node for two reasons:
    1. There is no other use of cpu_dev and can be simplified
    2. It enabled the use detect_cache_attributes and hence cache_setup_of_node
    much earlier before the CPUs are registered as devices.

    Link: https://lore.kernel.org/r/20220621192034.3332546-3-sudeep.holla@arm.com
    Tested-by: Ionela Voinescu <ionela.voinescu@arm.com>
    Reviewed-by: Gavin Shan <gshan@redhat.com>
    Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
    ---
    drivers/base/cacheinfo.c | 9 ++-------
    1 file changed, 2 insertions(+), 7 deletions(-)

    diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c
    index dad296229161..b0bde272e2ae 100644
    --- a/drivers/base/cacheinfo.c
    +++ b/drivers/base/cacheinfo.c
    @@ -14,7 +14,7 @@
    #include <linux/cpu.h>
    #include <linux/device.h>
    #include <linux/init.h>
    -#include <linux/of.h>
    +#include <linux/of_device.h>
    #include <linux/sched.h>
    #include <linux/slab.h>
    #include <linux/smp.h>
    @@ -157,7 +157,6 @@ static int cache_setup_of_node(unsigned int cpu)
    {
    struct device_node *np;
    struct cacheinfo *this_leaf;
    - struct device *cpu_dev = get_cpu_device(cpu);
    struct cpu_cacheinfo *this_cpu_ci = get_cpu_cacheinfo(cpu);
    unsigned int index = 0;

    @@ -166,11 +165,7 @@ static int cache_setup_of_node(unsigned int cpu)
    return 0;
    }

    - if (!cpu_dev) {
    - pr_err("No cpu device for CPU %d\n", cpu);
    - return -ENODEV;
    - }
    - np = cpu_dev->of_node;
    + np = of_cpu_device_node_get(cpu);
    if (!np) {
    pr_err("Failed to find cpu%d device node\n", cpu);
    return -ENOENT;
    --
    2.36.1
    \
     
     \ /
      Last update: 2022-06-27 18:51    [W:10.001 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site