lkml.org 
[lkml]   [2022]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 6/8] rcuscale: Add test for using call_rcu_lazy() to emulate kfree_rcu()
Hi "Joel,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.19-rc3 next-20220622]
[cannot apply to paulmck-rcu/dev]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/Joel-Fernandes-Google/Implement-call_rcu_lazy-and-miscellaneous-fixes/20220623-065447
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git de5c208d533a46a074eb46ea17f672cc005a7269
config: s390-randconfig-r044-20220622 (https://download.01.org/0day-ci/archive/20220623/202206231028.gVHd7wR5-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 46be5faaf03466c3751f8a2882bef5a217e15926)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install s390 cross compiling tool for clang build
# apt-get install binutils-s390x-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/6c59cb940f39b882c20e6858c41df7c1470b930a
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Joel-Fernandes-Google/Implement-call_rcu_lazy-and-miscellaneous-fixes/20220623-065447
git checkout 6c59cb940f39b882c20e6858c41df7c1470b930a
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

/opt/cross/gcc-11.3.0-nolibc/s390x-linux/bin/s390x-linux-ld: kernel/rcu/rcuscale.o: in function `kfree_scale_init':
>> kernel/rcu/rcuscale.c:810: undefined reference to `rcu_scale_get_jiffies_till_flush'
>> /opt/cross/gcc-11.3.0-nolibc/s390x-linux/bin/s390x-linux-ld: kernel/rcu/rcuscale.c:813: undefined reference to `rcu_scale_set_jiffies_till_flush'
/opt/cross/gcc-11.3.0-nolibc/s390x-linux/bin/s390x-linux-ld: kernel/rcu/rcuscale.c:822: undefined reference to `rcu_scale_set_jiffies_till_flush'
/opt/cross/gcc-11.3.0-nolibc/s390x-linux/bin/s390x-linux-ld: certs/system_keyring.o: in function `load_system_certificate_list':
certs/system_keyring.c:207: undefined reference to `x509_load_certificate_list'
/opt/cross/gcc-11.3.0-nolibc/s390x-linux/bin/s390x-linux-ld: drivers/dma/fsl-edma.o: in function `fsl_edma_probe':
drivers/dma/fsl-edma.c:302: undefined reference to `devm_ioremap_resource'
/opt/cross/gcc-11.3.0-nolibc/s390x-linux/bin/s390x-linux-ld: drivers/dma/fsl-edma.c:327: undefined reference to `devm_ioremap_resource'
/opt/cross/gcc-11.3.0-nolibc/s390x-linux/bin/s390x-linux-ld: drivers/dma/idma64.o: in function `idma64_platform_probe':
drivers/dma/idma64.c:644: undefined reference to `devm_ioremap_resource'
/opt/cross/gcc-11.3.0-nolibc/s390x-linux/bin/s390x-linux-ld: drivers/clocksource/timer-of.o: in function `timer_of_init':
drivers/clocksource/timer-of.c:151: undefined reference to `iounmap'
/opt/cross/gcc-11.3.0-nolibc/s390x-linux/bin/s390x-linux-ld: drivers/clocksource/timer-of.o: in function `timer_of_base_init':
drivers/clocksource/timer-of.c:159: undefined reference to `of_iomap'
/opt/cross/gcc-11.3.0-nolibc/s390x-linux/bin/s390x-linux-ld: drivers/clocksource/timer-of.o: in function `timer_of_cleanup':
drivers/clocksource/timer-of.c:151: undefined reference to `iounmap'


vim +810 kernel/rcu/rcuscale.c

794
795 static int __init
796 kfree_scale_init(void)
797 {
798 long i;
799 int firsterr = 0;
800 unsigned long orig_jif, jif_start;
801
802 // Force all call_rcu() to call_rcu_lazy() so that non-lazy CBs
803 // do not remove laziness of the lazy ones (since the test tries
804 // to stress call_rcu_lazy() for OOM).
805 //
806 // Also, do a quick self-test to ensure laziness is as much as
807 // expected.
808 if (kfree_rcu_by_lazy) {
809 /* do a test to check the timeout. */
> 810 orig_jif = rcu_scale_get_jiffies_till_flush();
811
812 rcu_force_call_rcu_to_lazy(true);
> 813 rcu_scale_set_jiffies_till_flush(2 * HZ);
814 rcu_barrier();
815
816 jif_start = jiffies;
817 jiffies_at_lazy_cb = 0;
818 call_rcu_lazy(&lazy_test1_rh, call_rcu_lazy_test1);
819
820 smp_cond_load_relaxed(&rcu_lazy_test1_cb_called, VAL == 1);
821
822 rcu_scale_set_jiffies_till_flush(orig_jif);
823
824 if (WARN_ON_ONCE(jiffies_at_lazy_cb - jif_start < 2 * HZ)) {
825 pr_alert("Lazy CBs are not being lazy as expected!\n");
826 return -1;
827 }
828
829 if (WARN_ON_ONCE(jiffies_at_lazy_cb - jif_start > 3 * HZ)) {
830 pr_alert("Lazy CBs are being too lazy!\n");
831 return -1;
832 }
833 }
834
835 kfree_nrealthreads = compute_real(kfree_nthreads);
836 /* Start up the kthreads. */
837 if (shutdown) {
838 init_waitqueue_head(&shutdown_wq);
839 firsterr = torture_create_kthread(kfree_scale_shutdown, NULL,
840 shutdown_task);
841 if (torture_init_error(firsterr))
842 goto unwind;
843 schedule_timeout_uninterruptible(1);
844 }
845
846 pr_alert("kfree object size=%zu, kfree_rcu_by_lazy=%d\n",
847 kfree_mult * sizeof(struct kfree_obj),
848 kfree_rcu_by_lazy);
849
850 kfree_reader_tasks = kcalloc(kfree_nrealthreads, sizeof(kfree_reader_tasks[0]),
851 GFP_KERNEL);
852 if (kfree_reader_tasks == NULL) {
853 firsterr = -ENOMEM;
854 goto unwind;
855 }
856
857 for (i = 0; i < kfree_nrealthreads; i++) {
858 firsterr = torture_create_kthread(kfree_scale_thread, (void *)i,
859 kfree_reader_tasks[i]);
860 if (torture_init_error(firsterr))
861 goto unwind;
862 }
863
864 while (atomic_read(&n_kfree_scale_thread_started) < kfree_nrealthreads)
865 schedule_timeout_uninterruptible(1);
866
867 torture_init_end();
868 return 0;
869
870 unwind:
871 torture_init_end();
872 kfree_scale_cleanup();
873 return firsterr;
874 }
875

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-06-23 05:04    [W:0.253 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site