Messages in this thread |  | | Date | Mon, 9 May 2022 16:19:03 +0200 | From | Greg KH <> | Subject | Re: [PATCHv2] speakup: Generate speakupmap.h automatically |
| |
On Mon, May 09, 2022 at 04:07:05PM +0200, Samuel Thibault wrote: > Hello, > > Greg KH, le lun. 09 mai 2022 16:04:43 +0200, a ecrit: > > Any reason you can't add the code in utils.c into genmap.c and then > > merge into makemapdata.c to make this a single .c file that does both > > things? > > Yes: genmap is a tool that end-users can use without needing the Linux > source code, while makemapdata needs it.
But who will run genmap?
Also you could just put the 90 lines of code into the .h file as inline functions to get rid of the utils.c to make it a bit simpler.
thanks,
greg k-h
|  |