lkml.org 
[lkml]   [2022]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2] speakup: Generate speakupmap.h automatically
On Sat, Apr 30, 2022 at 09:33:21AM +0200, Samuel Thibault wrote:
> speakupmap.h was not actually intended to be source code, speakupmap.map
> is.
>
> This resurrects the makemapdata.c and genmap.c tools to generate
> speakupmap.h automatically from the input and speakup headers, and the
> speakupmap.map keyboard mapping source file.
>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>
> ---
> difference with v1:
> - Add missing dependency between main.c and speakupmap.h
>
> drivers/accessibility/speakup/Makefile | 28 ++++
> drivers/accessibility/speakup/genmap.c | 162 ++++++++++++++++++++++++++++
> drivers/accessibility/speakup/makemapdata.c | 125 +++++++++++++++++++++
> drivers/accessibility/speakup/speakupmap.h | 66 -----------
> drivers/accessibility/speakup/utils.c | 92 +++++++++++++++
> drivers/accessibility/speakup/utils.h | 33 +++++
> 6 files changed, 440 insertions(+), 66 deletions(-)

Any reason you can't add the code in utils.c into genmap.c and then
merge into makemapdata.c to make this a single .c file that does both
things?

And when this is applied, I get the following "extra" files in the tree
that need to be properly ignored, so I couldn't take this as-is anyway:

❯ git status
On branch work-testing
Untracked files:
(use "git add <file>..." to include in what will be committed)
drivers/accessibility/speakup/genmap
drivers/accessibility/speakup/makemapdata
drivers/accessibility/speakup/mapdata.h
drivers/accessibility/speakup/speakupmap.h

nothing added to commit but untracked files present (use "git add" to track)

thanks,

greg k-h

\
 
 \ /
  Last update: 2022-05-09 16:09    [W:0.042 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site