lkml.org 
[lkml]   [2022]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 5/5] iommu/vt-d: Remove hard coding PGSNP bit in PASID entries
From
On 2022/5/2 21:19, Jason Gunthorpe wrote:
> On Sun, May 01, 2022 at 07:24:34PM +0800, Lu Baolu wrote:
>> As enforce_cache_coherency has been introduced into the iommu_domain_ops,
>> the kernel component which owns the iommu domain is able to opt-in its
>> requirement for force snooping support. The iommu driver has no need to
>> hard code the page snoop control bit in the PASID table entries anymore.
>>
>> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
>> ---
>> drivers/iommu/intel/pasid.h | 1 -
>> drivers/iommu/intel/iommu.c | 3 ---
>> drivers/iommu/intel/pasid.c | 6 ------
>> 3 files changed, 10 deletions(-)
>
> It seems fine, but as in the other email where do we do
> pasid_set_pgsnp() for a new device attach on an already no-snopp domain?

Yes. I will take care of this in the next version.

> Jason

Best regards,
baolu

\
 
 \ /
  Last update: 2022-05-04 10:54    [W:0.079 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site