lkml.org 
[lkml]   [2022]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/6] mm/page_alloc: Split out buddy removal code from rmqueue into separate helper
On Mon, May 23, 2022 at 05:09:21PM +0100, Qais Yousef wrote:
> On 05/12/22 09:50, Mel Gorman wrote:
> > This is a preparation page to allow the buddy removal code to be reused
> > in a later patch.
> >
> > No functional change.
> >
> > Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
> > Tested-by: Minchan Kim <minchan@kernel.org>
> > Acked-by: Minchan Kim <minchan@kernel.org>
> > ---
>
> I see this splat when this patch is applied on 5.10.107 kernel:
>

<SNIP>

> I could resolve it by applying this patch:
>
> diff --git a/mm/vmstat.c b/mm/vmstat.c
> index 80c1e0a0f094e..92fb0c08296ef 100644
> --- a/mm/vmstat.c
> +++ b/mm/vmstat.c
> @@ -957,11 +957,11 @@ void __inc_numa_state(struct zone *zone,
> u16 __percpu *p = pcp->vm_numa_stat_diff + item;
> u16 v;
>
> - v = __this_cpu_inc_return(*p);
> + v = this_cpu_inc_return(*p);
>
> if (unlikely(v > NUMA_STATS_THRESHOLD)) {
> zone_numa_state_add(v, zone, item);
> - __this_cpu_write(*p, 0);
> + this_cpu_write(*p, 0);
> }
> }
>

5.18 does not have __inc_numa_state() so it's likely you are missing
backports, probably f19298b9516c1a031b34b4147773457e3efe743b at minimum.

--
Mel Gorman
SUSE Labs

\
 
 \ /
  Last update: 2022-05-24 13:56    [W:0.088 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site