lkml.org 
[lkml]   [2022]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [v5 00/14] Add support for Bosch BNO055 IMU
On Mon, May 2, 2022 at 8:33 AM Andrea Merello <andrea.merello@gmail.com> wrote:
> Il giorno dom 1 mag 2022 alle ore 18:54 Jonathan Cameron
> <jic23@kernel.org> ha scritto:
> > On Wed, 27 Apr 2022 15:42:49 +0200
> > Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > > On Tue, Apr 26, 2022 at 3:11 PM Andrea Merello <andrea.merello@gmail.com> wrote:

...

> > > FWIW,
> > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > > for non-commented patches (12 out of 14 AFAICS).
> > >
> > FWIW I'm fine with the series once you've tidied up the stuff Andy picked up
> > on.
> >
> > Thanks Andy for the detailed reviewing btw.

You/re welcome!

> I'm very grateful to both of you and to everyone who commented on
> those patches. Thanks :). Beside the "Reviewed-by" tags where
> appropriate, is it usual/appropriate to put some tag like "Thanks-to
> .. [for comments]" ?

Nope, just mention that in the cover letter.

> BTW I have also gone through some kernel-robot reports; they also
> state "If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>". I'd say that it would
> be OK to add this tag to a patch that just fixes what is reported, but
> I'm unsure whether it is appropriate to add this tag to the patches in
> my series, because they add the code and the fix at once. Any advice
> here?

For this we specifically amended the kernel documentation recently.
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes

"The tag is intended for bugs; please do not use it to credit feature requests."

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2022-05-02 09:49    [W:0.096 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site