lkml.org 
[lkml]   [2022]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [asahilinux:asahi-soc/rtkit-sart-nvme 4/6] drivers/soc/apple/sart.c:284:4: warning: format specifies type 'unsigned long long' but the argument has type 'phys_addr_t' (aka 'unsigned int')
Hi Arnd,

On Mon, May 2, 2022, at 08:39, Arnd Bergmann wrote:
> On Mon, May 2, 2022 at 2:21 AM kernel test robot <lkp@intel.com> wrote:
>
>> 277
>> 278 clear_bit(i, &sart->used_entries);
>> 279 dev_dbg(sart->dev, "cleared entry %d\n", i);
>> 280 return 0;
>> 281 }
>> 282
>> 283 dev_warn(sart->dev, "entry [paddr: 0x%llx, size: 0x%zx] not found\n",
>> > 284 paddr, size);
>> 285
>
> Hi Sven,
>
> to print a phys_addr_t, you should pass the address by reference and use
> the special "%pap" format string modifier. I'm not entirely sure if it should
> actually be a dma_addr_t instead of a phys_addr_t. If the type gets changed,
> the format string would become "%pad".

I've been using %pa for all other prints in this file since v1 and just
missed this one for some reason. I'm a bit confused why the bots found this last
one only now but I'll fix it as well.


Thanks,

Sven

\
 
 \ /
  Last update: 2022-05-02 09:35    [W:0.045 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site