[lkml]   [2022]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/3] of: overlay: add entry to of_overlay_action_name[]
On 5/2/22 12:00, Rob Herring wrote:
> On Sat, Apr 30, 2022 at 07:05:41PM -0500, wrote:
>> From: Frank Rowand <>
>> The values of enum of_overlay_notify_action are used to index into
>> array of_overlay_action_name. Add an entry to of_overlay_action_name
>> for the value recently added to of_overlay_notify_action.
>> Array of_overlay_action_name[] is moved into include/linux/of.h
>> adjacent to enum of_overlay_notify_action to make the connection
>> between the two more obvious if either is modified in the future.
>> The only use of of_overlay_action_name is for error reporting in
>> overlay_notify(). All callers of overlay_notify() report the same
>> error, but with fewer details. Remove the redundant error reports
>> in the callers.
>> Fixes: 067c098766c6 ("of: overlay: rework overlay apply and remove kfree()s")
>> Reported-by: Dan Carpenter <>
>> Signed-off-by: Frank Rowand <>
>> ---
>> drivers/of/overlay.c | 27 +++++----------------------
>> include/linux/of.h | 13 +++++++++++++
>> 2 files changed, 18 insertions(+), 22 deletions(-)
> This isn't applying for me.

Weird, patch can apply it, but 'git am' does not work. I see that when
I try that on your dt/next branch.

The problem seems to be that I did not create the series on top of
dt/next: 5f756a2eaa44 of: overlay: do not break notify on NOTIFY_{OK|STOP}.

I have rebased the series on top of that patch and am sending v2.


> Rob

 \ /
  Last update: 2022-05-02 20:19    [W:0.037 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site