lkml.org 
[lkml]   [2022]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [v5 00/14] Add support for Bosch BNO055 IMU
Il giorno dom 1 mag 2022 alle ore 18:54 Jonathan Cameron
<jic23@kernel.org> ha scritto:
>
> On Wed, 27 Apr 2022 15:42:49 +0200
> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>
> > On Tue, Apr 26, 2022 at 3:11 PM Andrea Merello <andrea.merello@gmail.com> wrote:
> > >
> > > From: Andrea Merello <andrea.merello@iit.it>
> > >
> > > This series (tries to) add support for Bosch BNO055 IMU to Linux IIO
> > > subsystem. It is made up several patches:
> > >
> > > 1/14 to 6/14: add some IIO modifiers, and their documentation, to the IIO
> > > core layer, in order to being able to expose the linear
> > > acceleration and Euler angles among standard attributes.
> > > Also update the IIO event monitor tool
> > >
> > > 7/14: fix binary attributes didn't work with IIO
> > >
> > > 8/14 to 11/14: add the core IIO BNO055 driver and documentation for sysfs
> > > attributes and DT bindings
> > >
> > > 12/14: adds serdev BNO055 driver to actually use the IMU via serial line
> > >
> > > 13/14: adds I2C BNO055 driver to actually use the IMU via I2C wiring
> > >
> > > 14/14: add a documentation file that describe the bno055 driver and
> > > specifically the calibration
> >
> > FWIW,
> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > for non-commented patches (12 out of 14 AFAICS).
> >
> FWIW I'm fine with the series once you've tidied up the stuff Andy picked up
> on.
>
> Thanks Andy for the detailed reviewing btw.
>
> Jonathan

I'm very grateful to both of you and to everyone who commented on
those patches. Thanks :). Beside the "Reviewed-by" tags where
appropriate, is it usual/appropriate to put some tag like "Thanks-to
.. [for comments]" ?

BTW I have also gone through some kernel-robot reports; they also
state "If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>". I'd say that it would
be OK to add this tag to a patch that just fixes what is reported, but
I'm unsure whether it is appropriate to add this tag to the patches in
my series, because they add the code and the fix at once. Any advice
here?

Andrea

\
 
 \ /
  Last update: 2022-05-02 08:34    [W:0.097 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site