lkml.org 
[lkml]   [2022]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/1] staging: vc04_services: Re-use generic struct s32_fract
Hi Andy,

I love your patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]

url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/staging-vc04_services-Re-use-generic-struct-s32_fract/20220502-200543
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 5fe7856ad59afc56a6ff35d091bfaddd1d4f4bce
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220502/202205022340.RcyzPlQJ-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/c0fbdbd092e007c2567a367389e86df9d1cd7ee3
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Andy-Shevchenko/staging-vc04_services-Re-use-generic-struct-s32_fract/20220502-200543
git checkout c0fbdbd092e007c2567a367389e86df9d1cd7ee3
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

drivers/staging/vc04_services/bcm2835-camera/controls.c: In function 'ctrl_set_rational':
>> drivers/staging/vc04_services/bcm2835-camera/controls.c:162:24: error: 'struct s32_fract' has no member named 'numumerator'; did you mean 'numerator'?
162 | rational_value.numumerator = ctrl->val;
| ^~~~~~~~~~~
| numerator


vim +162 drivers/staging/vc04_services/bcm2835-camera/controls.c

152
153 static int ctrl_set_rational(struct bcm2835_mmal_dev *dev,
154 struct v4l2_ctrl *ctrl,
155 const struct bcm2835_mmal_v4l2_ctrl *mmal_ctrl)
156 {
157 struct s32_fract rational_value;
158 struct vchiq_mmal_port *control;
159
160 control = &dev->component[COMP_CAMERA]->control;
161
> 162 rational_value.numumerator = ctrl->val;
163 rational_value.denominator = 100;
164
165 return vchiq_mmal_port_parameter_set(dev->instance, control,
166 mmal_ctrl->mmal_id,
167 &rational_value,
168 sizeof(rational_value));
169 }
170

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-05-02 17:42    [W:0.048 / U:2.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site