lkml.org 
[lkml]   [2022]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] dt-bindings: eeprom/at24: Add samsung,s524ad0xd1 compatible
On Tue, Apr 26, 2022 at 8:00 PM Rob Herring <robh@kernel.org> wrote:
>
> The samsung,s524ad0xd1 compatible is in use, but not documented. According
> to arch/arm/mach-s3c/mach-smdk6410.c, the samsung,s524ad0xd1 is compatible
> with the 24c128. As the schema requires a fallback compatible to the
> corresponding Atmel compatible, 'atmel,24c128' is added as a fallback.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> v2:
> - Fix the example in samsung,s3c2410-i2c.yaml
>
> Documentation/devicetree/bindings/eeprom/at24.yaml | 4 +++-

For at24 part:

Acked-by: Bartosz Golaszewski <brgl@bgdev.pl>

> .../devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml | 2 +-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
> index 6b61a8cf6137..d14e0accbda8 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.yaml
> +++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
> @@ -120,7 +120,9 @@ properties:
> - const: giantec,gt24c32a
> - const: atmel,24c32
> - items:
> - - const: renesas,r1ex24128
> + - enum:
> + - renesas,r1ex24128
> + - samsung,s524ad0xd1
> - const: atmel,24c128
>
> label:
> diff --git a/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml b/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml
> index c26230518957..3d5782deb97d 100644
> --- a/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml
> @@ -123,7 +123,7 @@ examples:
> samsung,i2c-slave-addr = <0x66>;
>
> eeprom@50 {
> - compatible = "samsung,s524ad0xd1";
> + compatible = "samsung,s524ad0xd1", "atmel,24c128";
> reg = <0x50>;
> };
> };
> --
> 2.34.1
>

\
 
 \ /
  Last update: 2022-05-02 14:03    [W:0.076 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site