lkml.org 
[lkml]   [2022]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [Intel-wired-lan] [PATCH v5] igb: Convert kmap() to kmap_local_page()
Date


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Ira Weiny
> Sent: Thursday, April 21, 2022 11:19 PM
> To: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
> Cc: outreachy@lists.linux.dev; intel-wired-lan@lists.osuosl.org; linux-
> kernel@vger.kernel.org; netdev@vger.kernel.org; kuba@kernel.org;
> pabeni@redhat.com; davem@davemloft.net
> Subject: Re: [Intel-wired-lan] [PATCH v5] igb: Convert kmap() to
> kmap_local_page()
>
> On Wed, Apr 20, 2022 at 01:43:13AM +0200, Alaa Mohamed wrote:
> > kmap() is being deprecated and these usages are all local to the
> > thread so there is no reason kmap_local_page() can't be used.
> >
> > Replace kmap() calls with kmap_local_page().
> >
> > Signed-off-by: Alaa Mohamed
> <eng.alaamohamedsoliman.am@gmail.com>
>
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
>
> > ---
> > changes in V2:
> > fix kunmap_local path value to take address of the mapped page.
> > ---
> > changes in V3:
> > edit commit message to be clearer
> > ---
> > changes in V4:
> > edit the commit message
> > ---
> > changes in V5:
> > -edit commit subject
> > -edit commit message
> > ---
> > drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >

Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)

\
 
 \ /
  Last update: 2022-05-02 11:32    [W:0.076 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site