lkml.org 
[lkml]   [2022]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] iommu: fix an incorrect NULL check on list iterator
Hi Xiaomeng,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on joro-iommu/next]
[also build test ERROR on v5.18-rc5 next-20220429]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/Xiaomeng-Tong/iommu-fix-an-incorrect-NULL-check-on-list-iterator/20220501-211400
base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20220502/202205021754.GETHfNnS-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/99e334beef5d5be25ed19d3142d16000f0a1986d
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Xiaomeng-Tong/iommu-fix-an-incorrect-NULL-check-on-list-iterator/20220501-211400
git checkout 99e334beef5d5be25ed19d3142d16000f0a1986d
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

drivers/iommu/msm_iommu.c: In function 'qcom_iommu_of_xlate':
>> drivers/iommu/msm_iommu.c:629:17: error: 'ret' undeclared (first use in this function); did you mean 'net'?
629 | ret = -ENODEV;
| ^~~
| net
drivers/iommu/msm_iommu.c:629:17: note: each undeclared identifier is reported only once for each function it appears in
drivers/iommu/msm_iommu.c:638:1: error: control reaches end of non-void function [-Werror=return-type]
638 | }
| ^
cc1: some warnings being treated as errors


vim +629 drivers/iommu/msm_iommu.c

f78ebca8ff3d61 Sricharan R 2016-06-13 614
f78ebca8ff3d61 Sricharan R 2016-06-13 615 static int qcom_iommu_of_xlate(struct device *dev,
f78ebca8ff3d61 Sricharan R 2016-06-13 616 struct of_phandle_args *spec)
f78ebca8ff3d61 Sricharan R 2016-06-13 617 {
99e334beef5d5b Xiaomeng Tong 2022-05-01 618 struct msm_iommu_dev *iommu = NULL, *iter;
f78ebca8ff3d61 Sricharan R 2016-06-13 619 unsigned long flags;
f78ebca8ff3d61 Sricharan R 2016-06-13 620
f78ebca8ff3d61 Sricharan R 2016-06-13 621 spin_lock_irqsave(&msm_iommu_lock, flags);
99e334beef5d5b Xiaomeng Tong 2022-05-01 622 list_for_each_entry(iter, &qcom_iommu_devices, dev_node)
99e334beef5d5b Xiaomeng Tong 2022-05-01 623 if (iter->dev->of_node == spec->np) {
99e334beef5d5b Xiaomeng Tong 2022-05-01 624 iommu = iter;
f78ebca8ff3d61 Sricharan R 2016-06-13 625 break;
99e334beef5d5b Xiaomeng Tong 2022-05-01 626 }
f78ebca8ff3d61 Sricharan R 2016-06-13 627
99e334beef5d5b Xiaomeng Tong 2022-05-01 628 if (!iommu) {
f78ebca8ff3d61 Sricharan R 2016-06-13 @629 ret = -ENODEV;
f78ebca8ff3d61 Sricharan R 2016-06-13 630 goto fail;
f78ebca8ff3d61 Sricharan R 2016-06-13 631 }
f78ebca8ff3d61 Sricharan R 2016-06-13 632
bb5bdc5ab7f133 Xiaoke Wang 2022-04-28 633 ret = insert_iommu_master(dev, &iommu, spec);
f78ebca8ff3d61 Sricharan R 2016-06-13 634 fail:
f78ebca8ff3d61 Sricharan R 2016-06-13 635 spin_unlock_irqrestore(&msm_iommu_lock, flags);
f78ebca8ff3d61 Sricharan R 2016-06-13 636
f78ebca8ff3d61 Sricharan R 2016-06-13 637 return ret;
f78ebca8ff3d61 Sricharan R 2016-06-13 638 }
f78ebca8ff3d61 Sricharan R 2016-06-13 639

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-05-02 11:16    [W:0.357 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site