[lkml]   [2022]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2] staging: vchiq_arm: change vchiq_platform_init from global to static
Hi Tom,

I love your patch! Perhaps something to improve:

[auto build test WARNING on staging/staging-testing]

base: bed6d200f8ca38e1ecbdd8fb7e0564884002abd1
config: openrisc-buildonly-randconfig-r003-20220501 (
compiler: or1k-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add linux-review
git fetch --no-tags linux-review Tom-Rix/staging-vchiq_arm-change-vchiq_platform_init-from-global-to-static/20220419-213849
git checkout 36525447e8cdf4a25d5217bffc548768c0f7cec1
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=openrisc SHELL=/bin/bash drivers/staging/vc04_services/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <>

All warnings (new ones prefixed by >>):

In file included from drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:16:
In function 'memcpy_to_page',
inlined from 'free_pagelist' at drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:434:4:
>> include/linux/highmem.h:353:9: warning: argument 2 null where non-null expected [-Wnonnull]
353 | memcpy(to + offset, from, len);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/linux/string.h:20,
from include/linux/bitmap.h:11,
from include/linux/cpumask.h:12,
from include/linux/mm_types_task.h:14,
from include/linux/mm_types.h:5,
from include/linux/buildid.h:5,
from include/linux/module.h:14,
from drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:8:
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c: In function 'free_pagelist':
arch/openrisc/include/asm/string.h:9:14: note: in a call to function 'memcpy' declared 'nonnull'
9 | extern void *memcpy(void *dest, __const void *src, __kernel_size_t n);
| ^~~~~~
In file included from drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:16:
In function 'memcpy_to_page',
inlined from 'free_pagelist' at drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:441:4:
>> include/linux/highmem.h:353:9: warning: 'memcpy' offset 0 is out of the bounds [0, 0] [-Warray-bounds]
353 | memcpy(to + offset, from, len);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +353 include/linux/highmem.h

bb90d4bc7b6a53 Ira Weiny 2021-02-09 346
bb90d4bc7b6a53 Ira Weiny 2021-02-09 347 static inline void memcpy_to_page(struct page *page, size_t offset,
bb90d4bc7b6a53 Ira Weiny 2021-02-09 348 const char *from, size_t len)
bb90d4bc7b6a53 Ira Weiny 2021-02-09 349 {
61b205f579911a Ira Weiny 2021-02-09 350 char *to = kmap_local_page(page);
bb90d4bc7b6a53 Ira Weiny 2021-02-09 351
ca18f6ea012bf3 Ira Weiny 2021-02-10 352 VM_BUG_ON(offset + len > PAGE_SIZE);
bb90d4bc7b6a53 Ira Weiny 2021-02-09 @353 memcpy(to + offset, from, len);
8dad53a11f8d94 Christoph Hellwig 2021-07-23 354 flush_dcache_page(page);
61b205f579911a Ira Weiny 2021-02-09 355 kunmap_local(to);
bb90d4bc7b6a53 Ira Weiny 2021-02-09 356 }
bb90d4bc7b6a53 Ira Weiny 2021-02-09 357

0-DAY CI Kernel Test Service

 \ /
  Last update: 2022-05-03 05:15    [W:0.074 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site