lkml.org 
[lkml]   [2022]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 6/8] rpmsg: qcom: correct kerneldoc
From
Date
Quoting Krzysztof Kozlowski (2022-05-01 03:35:18)
> Correct kerneldoc warnings like:
>
> drivers/rpmsg/qcom_glink_ssr.c:45:
> warning: expecting prototype for G(). Prototype was for GLINK_SSR_DO_CLEANUP() instead
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Reviewed-by: Stephen Boyd <sboyd@kernel.org>

> drivers/rpmsg/qcom_glink_ssr.c | 2 +-
> drivers/rpmsg/qcom_smd.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rpmsg/qcom_glink_ssr.c b/drivers/rpmsg/qcom_glink_ssr.c
> index dea929c6045d..776d64446879 100644
> --- a/drivers/rpmsg/qcom_glink_ssr.c
> +++ b/drivers/rpmsg/qcom_glink_ssr.c
> @@ -39,7 +39,7 @@ struct cleanup_done_msg {
> __le32 seq_num;
> };
>
> -/**
> +/*
> * G-Link SSR protocol commands
> */
> #define GLINK_SSR_DO_CLEANUP 0
> diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c
> index 7c8c29f6c91d..e7e49d972d36 100644
> --- a/drivers/rpmsg/qcom_smd.c
> +++ b/drivers/rpmsg/qcom_smd.c
> @@ -729,7 +729,7 @@ static int qcom_smd_write_fifo(struct qcom_smd_channel *channel,
> }
>
> /**
> - * qcom_smd_send - write data to smd channel
> + * __qcom_smd_send - write data to smd channel
> * @channel: channel handle
> * @data: buffer of data to write
> * @len: number of bytes to write

Not part of this patch but it says "flag to indicate if write has ca
wait" and I wonder what "ca" means.

\
 
 \ /
  Last update: 2022-05-19 02:12    [W:0.295 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site