[lkml]   [2022]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 21/48] ARM: pxa: eseries: use gpio lookup for audio
On Tue, Apr 19, 2022 at 6:41 PM Arnd Bergmann <> wrote:

> From: Arnd Bergmann <>
> The three eseries machines have very similar drivers for audio, all
> using the mach/eseries-gpio.h header for finding the gpio numbers.
> Change these to use gpio descriptors to avoid the header file
> dependency.
> I convert the _OFF gpio numbers into GPIO_ACTIVE_LOW ones for
> consistency here.
> Acked-by: Mark Brown <>
> Acked-by: Robert Jarzmik <>
> Reviewed-by: Linus Walleij <>
> Cc:
> Signed-off-by: Arnd Bergmann <>

Nice use of active low. Maybe I would simply have dropped
the _OFF suffix on these GPIO lines as it can be confusing now
that their active level is encoded but no big deal.
Reviewed-by: Linus Walleij <>

Linus Walleij

 \ /
  Last update: 2022-05-01 23:46    [W:0.322 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site