Messages in this thread |  | | Date | Sun, 1 May 2022 22:38:07 +0800 | From | kernel test robot <> | Subject | [ammarfaizi2-block:crng/random/jd/premature-next 22/22] drivers/char/random.c:966:17: error: too many arguments to function 'crng_reseed' |
| |
tree: https://github.com/ammarfaizi2/linux-block crng/random/jd/premature-next head: 0f5d33eaa0e077a5d2dfee756ebf254686f268bd commit: 0f5d33eaa0e077a5d2dfee756ebf254686f268bd [22/22] random: do not pretend to handle premature-next model config: powerpc-allnoconfig (https://download.01.org/0day-ci/archive/20220501/202205012224.yDMg4Wy1-lkp@intel.com/config) compiler: powerpc-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/ammarfaizi2/linux-block/commit/0f5d33eaa0e077a5d2dfee756ebf254686f268bd git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block git fetch --no-tags ammarfaizi2-block crng/random/jd/premature-next git checkout 0f5d33eaa0e077a5d2dfee756ebf254686f268bd # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/char/
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/char/random.c: In function 'random_pm_notification': >> drivers/char/random.c:966:17: error: too many arguments to function 'crng_reseed' 966 | crng_reseed(true); | ^~~~~~~~~~~ drivers/char/random.c:265:13: note: declared here 265 | static void crng_reseed(void) | ^~~~~~~~~~~
vim +/crng_reseed +966 drivers/char/random.c
3655adc7089da4 Jason A. Donenfeld 2022-02-11 942 da1a2e23f28eac Jason A. Donenfeld 2022-05-01 943 static int random_pm_notification(struct notifier_block *nb, unsigned long action, void *data) da1a2e23f28eac Jason A. Donenfeld 2022-05-01 944 { da1a2e23f28eac Jason A. Donenfeld 2022-05-01 945 unsigned long flags, entropy = random_get_entropy(); da1a2e23f28eac Jason A. Donenfeld 2022-05-01 946 da1a2e23f28eac Jason A. Donenfeld 2022-05-01 947 /* da1a2e23f28eac Jason A. Donenfeld 2022-05-01 948 * Encode a representation of how long the system has been suspended, da1a2e23f28eac Jason A. Donenfeld 2022-05-01 949 * in a way that is distinct from prior system suspends. da1a2e23f28eac Jason A. Donenfeld 2022-05-01 950 */ da1a2e23f28eac Jason A. Donenfeld 2022-05-01 951 ktime_t stamps[] = { da1a2e23f28eac Jason A. Donenfeld 2022-05-01 952 ktime_get(), da1a2e23f28eac Jason A. Donenfeld 2022-05-01 953 ktime_get_boottime(), da1a2e23f28eac Jason A. Donenfeld 2022-05-01 954 ktime_get_real() da1a2e23f28eac Jason A. Donenfeld 2022-05-01 955 }; da1a2e23f28eac Jason A. Donenfeld 2022-05-01 956 da1a2e23f28eac Jason A. Donenfeld 2022-05-01 957 spin_lock_irqsave(&input_pool.lock, flags); da1a2e23f28eac Jason A. Donenfeld 2022-05-01 958 _mix_pool_bytes(&action, sizeof(action)); da1a2e23f28eac Jason A. Donenfeld 2022-05-01 959 _mix_pool_bytes(stamps, sizeof(stamps)); da1a2e23f28eac Jason A. Donenfeld 2022-05-01 960 _mix_pool_bytes(&entropy, sizeof(entropy)); da1a2e23f28eac Jason A. Donenfeld 2022-05-01 961 spin_unlock_irqrestore(&input_pool.lock, flags); da1a2e23f28eac Jason A. Donenfeld 2022-05-01 962 da1a2e23f28eac Jason A. Donenfeld 2022-05-01 963 if (crng_ready() && (action == PM_RESTORE_PREPARE || da1a2e23f28eac Jason A. Donenfeld 2022-05-01 964 (action == PM_POST_SUSPEND && da1a2e23f28eac Jason A. Donenfeld 2022-05-01 965 !IS_ENABLED(CONFIG_PM_AUTOSLEEP) && !IS_ENABLED(CONFIG_ANDROID)))) { da1a2e23f28eac Jason A. Donenfeld 2022-05-01 @966 crng_reseed(true); da1a2e23f28eac Jason A. Donenfeld 2022-05-01 967 pr_notice("crng reseeded on system resumption\n"); da1a2e23f28eac Jason A. Donenfeld 2022-05-01 968 } da1a2e23f28eac Jason A. Donenfeld 2022-05-01 969 return 0; da1a2e23f28eac Jason A. Donenfeld 2022-05-01 970 } da1a2e23f28eac Jason A. Donenfeld 2022-05-01 971
:::::: The code at line 966 was first introduced by commit :::::: da1a2e23f28eac7746add084c7807fffcf255f9d random: mix in timestamps and reseed on system restore
:::::: TO: Jason A. Donenfeld <Jason@zx2c4.com> :::::: CC: Jason A. Donenfeld <Jason@zx2c4.com>
-- 0-DAY CI Kernel Test Service https://01.org/lkp
|  |