Messages in this thread |  | | Date | Sat, 9 Apr 2022 18:25:24 +0200 | Subject | Re: [PATCH 1/2] dt-bindings: wkup-m3-ipc: Add vtt toggle bindings | From | Krzysztof Kozlowski <> |
| |
On 09/04/2022 06:51, Drew Fustini wrote: > Document the Wakeup M3 IPC properties that can be used to toggle the VTT > regulator during low power mode transitions. >
(...)
> @@ -51,6 +61,15 @@ properties: > mbox_wkupm3 child node. > maxItems: 1 > > + ti,needs-vtt-toggle: > + type: boolean > + description: boards requires VTT toggling during suspend/resume > + > + ti,vtt-gpio-pin: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: pin on the GPIO0 module used for VTT toggle > + maxItems: 1
No need for maxItems, it's a single uint32. You could add "maximum" if you know the constraints for the value.
Do you actually need two properties (bool + pin)? A case of "ti,vtt-gpio-pin" without the "ti,needs-vtt-toggle" is valid?
The other way looks wrong, so you need to add a dependency (see example-schema).
Best regards, Krzysztof
|  |