Messages in this thread |  | | Date | Fri, 8 Apr 2022 22:05:10 -0600 | Subject | Re: [PATCH RESEND net-next v5 3/4] net: icmp: introduce __ping_queue_rcv_skb() to report drop reasons | From | David Ahern <> |
| |
On 4/7/22 12:20 AM, menglong8.dong@gmail.com wrote: > From: Menglong Dong <imagedong@tencent.com> > > In order to avoid to change the return value of ping_queue_rcv_skb(), > introduce the function __ping_queue_rcv_skb(), which is able to report > the reasons of skb drop as its return value, as Paolo suggested. > > Meanwhile, make ping_queue_rcv_skb() a simple call to > __ping_queue_rcv_skb(). > > The kfree_skb() and sock_queue_rcv_skb() used in ping_queue_rcv_skb() > are replaced with kfree_skb_reason() and sock_queue_rcv_skb_reason() > now. > > Reviewed-by: Hao Peng <flyingpeng@tencent.com> > Reviewed-by: Jiang Biao <benbjiang@tencent.com> > Signed-off-by: Menglong Dong <imagedong@tencent.com> > --- > v4: > - fix the return value problem of ping_queue_rcv_skb() > > v3: > - fix aligenment problem > > v2: > - introduce __ping_queue_rcv_skb() instead of change the return value > of ping_queue_rcv_skb() > --- > net/ipv4/ping.c | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) >
Reviewed-by: David Ahern <dsahern@kernel.org>
|  |