Messages in this thread |  | | Date | Sat, 9 Apr 2022 18:41:25 +0200 | Subject | Re: [PATCH 1/2] dt-bindings: clock: Add Qualcomm SC8280XP GCC bindings | From | Krzysztof Kozlowski <> |
| |
On 09/04/2022 00:43, Bjorn Andersson wrote: > Add binding for the Qualcomm SC8280XP Global Clock controller. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > .../bindings/clock/qcom,gcc-sc8280xp.yaml | 199 +++++++ > include/dt-bindings/clock/qcom,gcc-sc8280xp.h | 496 ++++++++++++++++++ > 2 files changed, 695 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-sc8280xp.yaml > create mode 100644 include/dt-bindings/clock/qcom,gcc-sc8280xp.h > > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-sc8280xp.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-sc8280xp.yaml > new file mode 100644 > index 000000000000..44e5f0d0a795 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-sc8280xp.yaml > @@ -0,0 +1,199 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/qcom,gcc-sc8280xp.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Global Clock & Reset Controller Binding for SC8280xp > + > +maintainers: > + - Bjorn Andersson <bjorn.andersson@linaro.org> > + > +description: | > + Qualcomm global clock control module which supports the clocks, resets and > + power domains on SC8280xp. > + > + See also: > + - dt-bindings/clock/qcom,gcc-sc8280xp.h
include/dt-bindings/...
> + > +properties: > + compatible: > + const: qcom,gcc-sc8280xp > +
(...)
> + > + '#power-domain-cells': > + const: 1 > + > + reg: > + maxItems: 1 > + > + protected-clocks: > + description: > + Protected clock specifier list as per common clock binding.
There is still no schema with protected-clocks, so you need a type, unless someoone is working on adding this to schema?
Rest looks good.
Best regards, Krzysztof
|  |