Messages in this thread |  | | Date | Sat, 9 Apr 2022 15:20:29 +0200 | Subject | Re: [PATCH] block: Remove redundant assignments | From | Michal Orzel <> |
| |
Hi Tom,
> > On 4/9/22 3:19 AM, Michal Orzel wrote: >> Get rid of redundant assignments which end up in values not being >> read either because they are overwritten or the function ends. > > This log is the same as your last patch. > > Instead of a general statement on deadstores, a more specific > > analysis of the setting being removed would be helpful. > > This will mean splitting the patch to match the analysis. > > Tom >
I think that this explanation in a commit is enough for such a trivial patch. It informs that we are fixing clang-tidy findings related to deadstores in a block subsystem. What analysis would you want to see? Something like "Remove deadstore assignment ret = -EINVAL in a function bio_map_user_iov" ? I think that it will create too much of not needed overhead.
Cheers, Michal
|  |