[lkml]   [2022]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] block: Remove redundant assignments
Hi Tom,

> On 4/9/22 3:19 AM, Michal Orzel wrote:
>> Get rid of redundant assignments which end up in values not being
>> read either because they are overwritten or the function ends.
> This log is the same as your last patch.
> Instead of a general statement on deadstores, a more specific
> analysis of the setting being removed would be helpful.
> This will mean splitting the patch to match the analysis.
> Tom

I think that this explanation in a commit is enough for such a trivial patch.
It informs that we are fixing clang-tidy findings related to deadstores
in a block subsystem. What analysis would you want to see?
Something like "Remove deadstore assignment ret = -EINVAL in a function bio_map_user_iov" ?
I think that it will create too much of not needed overhead.


 \ /
  Last update: 2022-04-09 15:21    [W:0.034 / U:2.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site