Messages in this thread |  | | Date | Fri, 8 Apr 2022 22:17:30 -0600 | Subject | Re: [PATCH RESEND net-next v5 4/4] net: icmp: add skb drop reasons to icmp protocol | From | David Ahern <> |
| |
On 4/7/22 12:20 AM, menglong8.dong@gmail.com wrote: > From: Menglong Dong <imagedong@tencent.com> > > Replace kfree_skb() used in icmp_rcv() and icmpv6_rcv() with > kfree_skb_reason(). > > In order to get the reasons of the skb drops after icmp message handle, > we change the return type of 'handler()' in 'struct icmp_control' from > 'bool' to 'enum skb_drop_reason'. This may change its original > intention, as 'false' means failure, but 'SKB_NOT_DROPPED_YET' means > success now. Therefore, all 'handler' and the call of them need to be > handled. Following 'handler' functions are involved: > > icmp_unreach() > icmp_redirect() > icmp_echo() > icmp_timestamp() > icmp_discard() > > And following new drop reasons are added: > > SKB_DROP_REASON_ICMP_CSUM > SKB_DROP_REASON_INVALID_PROTO > > The reason 'INVALID_PROTO' is introduced for the case that the packet > doesn't follow rfc 1122 and is dropped. This is not a common case, and > I believe we can locate the problem from the data in the packet. For now, > this 'INVALID_PROTO' is used for the icmp broadcasts with wrong types. > > Maybe there should be a document file for these reasons. For example, > list all the case that causes the 'UNHANDLED_PROTO' and 'INVALID_PROTO' > drop reason. Therefore, users can locate their problems according to the > document. > > Reviewed-by: Hao Peng <flyingpeng@tencent.com> > Reviewed-by: Jiang Biao <benbjiang@tencent.com> > Signed-off-by: Menglong Dong <imagedong@tencent.com> > --- > v5: > - rename SKB_DROP_REASON_RFC_1122 to SKB_DROP_REASON_INVALID_PROTO > > v4: > - remove SKB_DROP_REASON_ICMP_TYPE and SKB_DROP_REASON_ICMP_BROADCAST > and introduce the SKB_DROP_REASON_RFC_1122 > --- > include/linux/skbuff.h | 5 +++ > include/net/ping.h | 2 +- > include/trace/events/skb.h | 2 + > net/ipv4/icmp.c | 75 ++++++++++++++++++++++---------------- > net/ipv4/ping.c | 14 ++++--- > net/ipv6/icmp.c | 24 +++++++----- > 6 files changed, 75 insertions(+), 47 deletions(-) >
Reviewed-by: David Ahern <dsahern@kernel.org>
|  |