Messages in this thread |  | | Date | Fri, 8 Apr 2022 21:12:55 -0700 | Subject | Re: [PATCH v2] drm/gma500: depend on framebuffer | From | Randy Dunlap <> |
| |
On 4/8/22 20:44, James Hilliard wrote: > This appears to be needed for video output to function correctly. > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com> > --- > Changes v1 -> v2: > - use depends instead of select
Thanks.
> --- > drivers/gpu/drm/gma500/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig > index 0cff20265f97..8ea87bfa95f5 100644 > --- a/drivers/gpu/drm/gma500/Kconfig > +++ b/drivers/gpu/drm/gma500/Kconfig > @@ -2,6 +2,8 @@ > config DRM_GMA500 > tristate "Intel GMA500/600/3600/3650 KMS Framebuffer" > depends on DRM && PCI && X86 && MMU > + depends on FB > + depends on FB_EFI || !EFI
I'm OK with the second line of the first patch:
+ select FB_EFI if EFI
It's just that a single driver shouldn't enable an entire subsystem (like FB) on its own. But once FB is set (depends on in this patch), selecting FB_EFI would be OK IMO.
> select DRM_KMS_HELPER > # GMA500 depends on ACPI_VIDEO when ACPI is enabled, just like i915 > select ACPI_VIDEO if ACPI
-- ~Randy
|  |