Messages in this thread |  | | Date | Tue, 5 Apr 2022 21:11:08 +0200 | Subject | Re: [RESEND PATCH 06/11] brcmfmac: sdio: Fix undefined behavior due to shift overflowing the constant | From | Arend van Spriel <> |
| |
On 4/5/2022 6:55 PM, Borislav Petkov wrote: > Fix: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c: In function ‘brcmf_sdio_drivestrengthinit’: > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3798:2: error: case label does not reduce to an integer constant > case SDIOD_DRVSTR_KEY(BRCM_CC_43143_CHIP_ID, 17): > ^~~~ > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:3809:2: error: case label does not reduce to an integer constant > case SDIOD_DRVSTR_KEY(BRCM_CC_43362_CHIP_ID, 13): > ^~~~ > > See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory > details as to why it triggers with older gccs only.
The details aren't that gory ;-)
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com> > Signed-off-by: Borislav Petkov <bp@suse.de> > Cc: Arend van Spriel <aspriel@gmail.com> > Cc: Franky Lin <franky.lin@broadcom.com> > Cc: Hante Meuleman <hante.meuleman@broadcom.com> > Cc: Kalle Valo <kvalo@kernel.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: brcm80211-dev-list.pdl@broadcom.com > Cc: netdev@vger.kernel.org [unhandled content-type:application/pkcs7-signature] |  |