Messages in this thread |  | | Date | Sun, 3 Apr 2022 12:44:26 +0530 | From | Kuldeep Singh <> | Subject | Re: [PATCH 6/6] dt-bindings: power: supply: qcom,smb2: add bindings for smb2 driver |
| |
On Fri, Apr 01, 2022 at 09:26:43PM +0100, Caleb Connolly wrote: > Add devicetree bindings for the Qualcomm PMI8998/PM660 SMB2 charger > drivers. > > Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> > --- > .../bindings/power/supply/qcom,smb2.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/qcom,smb2.yaml > > diff --git a/Documentation/devicetree/bindings/power/supply/qcom,smb2.yaml b/Documentation/devicetree/bindings/power/supply/qcom,smb2.yaml > new file mode 100644 > index 000000000000..1bea1fef78b8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/qcom,smb2.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/supply/qcom,smb2.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm PMI8998/PM660 Switch-Mode Battery Charger "2" > + > +maintainers: > + - Caleb Connolly <caleb.connolly@linaro.org> > + > +properties: > + compatible: > + enum: > + - qcom,pmi8998-smb2
Since there's only 1 entry, please use const.
> + > + reg: > + maxItems: 1 > + > + interrupts: > + items: > + - description: usb plugin > + > + interrupt-names: > + items: > + - const: usb-plugin > + > + io-channels: > + items: > + - description: USB in current in uA > + - description: USB in voltage in uV > + > + io-channel-names: > + items: > + - const: usbin_i > + - const: usbin_v > + > +required: > + - compatible > + - reg > + - interrupts > + - interrupt-names > + - io-channels > + - io-channel-names > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h>
New line here. Looks nice.
> + pmic { > + #address-cells = <1>; > + #size-cells = <0>; > + #interrupt-cells = <4>; > + > + smb2@1000 { > + compatible = "qcom,pmi8998-smb2"; > + reg = <0x1000>; > + > + interrupts = <0x2 0x13 0x4 IRQ_TYPE_EDGE_BOTH>; > + interrupt-names = "usb-plugin"; > +
In-between new lines may not be required. And DTs use tabs instead of 2 spaces, we can follow that here also.
> + io-channels = <&pmi8998_rradc 3>, > + <&pmi8998_rradc 4>; > + io-channel-names = "usbin_i", > + "usbin_v";
Channel-names can be written in one line.
> + }; > + }; > -- > 2.35.1 >
|  |