[lkml]   [2022]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH] raid6test: change dataoffs from global to static
Smatch reports this issue
raid6test.c:21:14: warning: symbol 'dataoffs'
was not declared. Should it be static?

dataoffs is only used in raid6test.c. File
scope variables used only in one file should
be static. Change dataoffs' storage-class-specifier
from global to static.

Signed-off-by: Tom Rix <>
crypto/async_tx/raid6test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/async_tx/raid6test.c b/crypto/async_tx/raid6test.c
index c9d218e53bcb..d2d5fb154cda 100644
--- a/crypto/async_tx/raid6test.c
+++ b/crypto/async_tx/raid6test.c
@@ -18,7 +18,7 @@
#define NDISKS 64 /* Including P and Q */

static struct page *dataptrs[NDISKS];
-unsigned int dataoffs[NDISKS];
+static unsigned int dataoffs[NDISKS];
static addr_conv_t addr_conv[NDISKS];
static struct page *data[NDISKS+3];
static struct page *spare;
 \ /
  Last update: 2022-04-03 15:32    [W:0.018 / U:12.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site