lkml.org 
[lkml]   [2022]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC v2 10/39] gpio: add HAS_IOPORT dependencies
    On Fri, Apr 29, 2022 at 03:50:16PM +0200, Niklas Schnelle wrote:
    > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
    > not being declared. We thus need to add HAS_IOPORT as dependency for
    > those drivers using them.
    >
    > Co-developed-by: Arnd Bergmann <arnd@kernel.org>
    > Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
    > ---
    > drivers/gpio/Kconfig | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
    > index 45764ec3b2eb..14e5998ee95c 100644
    > --- a/drivers/gpio/Kconfig
    > +++ b/drivers/gpio/Kconfig
    > @@ -697,7 +697,7 @@ config GPIO_VR41XX
    >
    > config GPIO_VX855
    > tristate "VIA VX855/VX875 GPIO"
    > - depends on (X86 || COMPILE_TEST) && PCI
    > + depends on (X86 || COMPILE_TEST) && PCI && HAS_IOPORT
    > select MFD_CORE
    > select MFD_VX855
    > help
    > --
    > 2.32.0

    I noticed a number of other GPIO drivers make use of inb()/outb() -- for
    example the PC104 drivers -- should the respective Kconfigs for those
    drivers also be adjusted here?

    William Breathitt Gray
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2022-04-29 16:33    [W:4.020 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site