Messages in this thread |  | | Date | Mon, 25 Apr 2022 00:52:39 +0300 | Subject | Re: [PATCH net-next v3 1/2] rtnetlink: add extack support in fdb del handlers | From | Nikolay Aleksandrov <> |
| |
On 4/25/22 00:09, Alaa Mohamed wrote: > > On ٢٤/٤/٢٠٢٢ ٢١:٥٥, Nikolay Aleksandrov wrote: >> On 24/04/2022 22:49, Alaa Mohamed wrote: >>> On ٢٤/٤/٢٠٢٢ ٢١:٠٢, Nikolay Aleksandrov wrote: >>>> On 24/04/2022 15:09, Alaa Mohamed wrote: >>>>> Add extack support to .ndo_fdb_del in netdevice.h and >>>>> all related methods. >>>>> >>>>> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com> >>>>> --- >>>>> changes in V3: >>>>> fix errors reported by checkpatch.pl >>>>> --- >>>>> drivers/net/ethernet/intel/ice/ice_main.c | 4 ++-- >>>>> drivers/net/ethernet/mscc/ocelot_net.c | 4 ++-- >>>>> drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 2 +- >>>>> drivers/net/macvlan.c | 2 +- >>>>> drivers/net/vxlan/vxlan_core.c | 2 +- >>>>> include/linux/netdevice.h | 2 +- >>>>> net/bridge/br_fdb.c | 2 +- >>>>> net/bridge/br_private.h | 2 +- >>>>> net/core/rtnetlink.c | 4 ++-- >>>>> 9 files changed, 12 insertions(+), 12 deletions(-) >>>>> >>>>> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c >>>>> b/drivers/net/ethernet/intel/ice/ice_main.c >>>>> index d768925785ca..7b55d8d94803 100644 >>>>> --- a/drivers/net/ethernet/intel/ice/ice_main.c >>>>> +++ b/drivers/net/ethernet/intel/ice/ice_main.c >>>>> @@ -5678,10 +5678,10 @@ ice_fdb_add(struct ndmsg *ndm, struct >>>>> nlattr __always_unused *tb[], >>>>> static int >>>>> ice_fdb_del(struct ndmsg *ndm, __always_unused struct nlattr *tb[], >>>>> struct net_device *dev, const unsigned char *addr, >>>>> - __always_unused u16 vid) >>>>> + __always_unused u16 vid, struct netlink_ext_ack *extack) >>>>> { >>>>> int err; >>>>> - >>>>> + >>>> What's changed here? >>> In the previous version, I removed the blank line after "int err;" >>> and you said I shouldn't so I added blank line. >>> >> Yeah, my question is are you fixing a dos ending or something else? >> The blank line is already there, what's wrong with it? > No, I didn't. >> >> The point is it's not nice to mix style fixes and other changes, more so >> if nothing is mentioned in the commit message. > Got it, So, what should I do to fix it?
Don't change that line? I mean I'm even surprised this made it in the patch. As I mentioned above, there is already a new line there so I'm not sure how you're removing it and adding it again. :)
Cheers, Nik
|  |