Messages in this thread |  | | From | Martin Blumenstingl <> | Date | Sun, 24 Apr 2022 21:36:12 +0200 | Subject | Re: [PATCH] clk: meson: meson8b: fix a memory leak in meson8b_clkc_init_common() |
| |
Hi Stephen,
On Sat, Apr 23, 2022 at 4:25 AM Stephen Boyd <sboyd@kernel.org> wrote: [...] > > Also a note about meson8b_clkc_init_common() itself: failures in that > > function will result in a non-working system. > > If we can't register the reset controller then most devices won't > > probe and CPU SMP cannot work. > > If registering any clock or the clock controller doesn't work then the > > system also won't work as clocks are not available to other drivers. > > So freeing memory in case of an error is good to have, but the end > > result is still the same: the system won't work. > > > > Can we get far enough to record this fact into either a pstore ramoops > location or the serial console? That would be ideal to make debugging > early problems easier. earlycon shows these messages (as it's enabled by the bootloader) while "normal" serial console won't come up without the corresponding clocks. I never tried ramoops but I expect it to be able to log these errors as well.
Best regards, Martin
|  |