[lkml]   [2022]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] erofs: make filesystem exportable
Hi Hongnan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on xiang-erofs/dev-test]
[also build test WARNING on v5.18-rc3 next-20220422]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in]

base: dev-test
config: hexagon-buildonly-randconfig-r005-20220424 (
compiler: clang version 15.0.0 ( 1cddcfdc3c683b393df1a5c9063252eb60e52818)
reproduce (this is a W=1 build):
wget -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add linux-review
git fetch --no-tags linux-review Hongnan-Li/erofs-make-filesystem-exportable/20220424-211653
git checkout c0fc15c5ccc4a5090cc32744ba63bde8ea558ac7
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash fs/erofs/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <>

All warnings (new ones prefixed by >>):

>> fs/erofs/super.c:601:16: warning: no previous prototype for function 'erofs_get_parent' [-Wmissing-prototypes]
struct dentry *erofs_get_parent(struct dentry *child)
fs/erofs/super.c:601:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
struct dentry *erofs_get_parent(struct dentry *child)
1 warning generated.

vim +/erofs_get_parent +601 fs/erofs/super.c

> 601 struct dentry *erofs_get_parent(struct dentry *child)
602 {
603 erofs_nid_t nid;
604 unsigned int d_type;
605 int err;
607 err = erofs_namei(d_inode(child), &dotdot_name, &nid, &d_type);
608 if (err)
609 return ERR_PTR(err);
610 return d_obtain_alias(erofs_iget(child->d_sb, nid, d_type == FT_DIR));
611 }

0-DAY CI Kernel Test Service

 \ /
  Last update: 2022-04-24 16:33    [W:0.090 / U:1.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site