Messages in this thread Patch in this message |  | | From | Michal Orzel <> | Subject | [PATCH RESEND v2 2/5] block/blk-map: Remove redundant assignment | Date | Sat, 23 Apr 2022 13:38:08 +0200 |
| |
Get rid of redundant assignment to a variable ret from function bio_map_user_iov as it is being assigned a value that is never read. It is being re-assigned in the first instruction after the while loop
Reported by clang-tidy [deadcode.DeadStores]
Signed-off-by: Michal Orzel <michalorzel.eng@gmail.com> --- block/blk-map.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/block/blk-map.c b/block/blk-map.c index c7f71d83eff1..fa72e63e18c2 100644 --- a/block/blk-map.c +++ b/block/blk-map.c @@ -260,10 +260,9 @@ static int bio_map_user_iov(struct request *rq, struct iov_iter *iter, npages = DIV_ROUND_UP(offs + bytes, PAGE_SIZE); - if (unlikely(offs & queue_dma_alignment(rq->q))) { - ret = -EINVAL; + if (unlikely(offs & queue_dma_alignment(rq->q))) j = 0; - } else { + else { for (j = 0; j < npages; j++) { struct page *page = pages[j]; unsigned int n = PAGE_SIZE - offs; -- 2.25.1
|  |