lkml.org 
[lkml]   [2022]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5] dt-bindings: qcom: geni-se: Remove common controller properties
On Sat, Apr 02, 2022 at 05:41:57PM +0200, Krzysztof Kozlowski wrote:
> On 02/04/2022 07:12, Kuldeep Singh wrote:
> > Now that Geni serial engine controllers(spi, i2c and uart) have their
> > own individual bindings, it's time to remove all common properties of
> > the controllers from parent schema.
> >
> > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
> > ---
> > .../bindings/soc/qcom/qcom,geni-se.yaml | 33 -------------------
> > 1 file changed, 33 deletions(-)
> >
>
> This should be squashed with your previous commit, because removal of
> last direct child schema, makes the common parts obsolete. IOW, the
> common parts are only because there is children are open-coded here.

Initially I thought the same, but then this patch will do more than what
commit description says, that's why I kept separate patch.

Nevermind, I will squash it with previous one.

-Kuldeep

\
 
 \ /
  Last update: 2022-04-02 21:33    [W:0.034 / U:35.724 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site