Messages in this thread |  | | Date | Sat, 2 Apr 2022 20:24:25 +0200 | Subject | Re: [PATCH 1/5] dt-bindings: i2c: Add Qualcomm Geni based QUP i2c bindings | From | Krzysztof Kozlowski <> |
| |
On 02/04/2022 07:12, Kuldeep Singh wrote: > GENI(generic interface) based Qualcomm Universal Peripheral controller > can support multiple serial interfaces like spi,uart and i2c. >
Few more comments.
(...)
> + > + clock-frequency: > + description: Desired I2C bus clock frequency in Hz
Skip description, it's common for I2C controllers.
> + default: 100000 > + > + interconnects: > + maxItems: 3 > + > + interconnect-names: > + items: > + - const: qup-core > + - const: qup-config > + - const: qup-memory > + > + interrupts: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + reg: > + maxItems: 1 > + > + required-opps: > + maxItems: 1 > + > + dmas: > + maxItems: 2 > + > + dma-names: > + items: > + - const: tx > + - const: rx > + > + pinctrl-0: true > + pinctrl-1: true > + > + pinctrl-names: > + minItems: 1 > + items: > + - const: default > + - const: sleep > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0
These are not needed, they come from schema.
Best regards, Krzysztof
|  |