lkml.org 
[lkml]   [2022]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 6/6] dt-bindings: power: supply: qcom,smb2: add bindings for smb2 driver
From


On 02/04/2022 15:22, Krzysztof Kozlowski wrote:
> On 01/04/2022 22:26, Caleb Connolly wrote:
>> Add devicetree bindings for the Qualcomm PMI8998/PM660 SMB2 charger
>> drivers.
>>
>> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
>> ---
>> .../bindings/power/supply/qcom,smb2.yaml | 68 +++++++++++++++++++
>> 1 file changed, 68 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/power/supply/qcom,smb2.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/power/supply/qcom,smb2.yaml b/Documentation/devicetree/bindings/power/supply/qcom,smb2.yaml
>> new file mode 100644
>> index 000000000000..1bea1fef78b8
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/power/supply/qcom,smb2.yaml
>> @@ -0,0 +1,68 @@
>> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/power/supply/qcom,smb2.yaml#
>
> Hi,
Hi Krzysztof,
>
> Are you sure "smb2" is a real Qualcomm versioning? IOW, is there going
> to be smb3 in the future? If not, better to just name the file according
> to model, so like compatible and like other existing schemas from Qualcomm.
Qualcomm versioning is a complete mystery to me 😅, downstream kernels have a
"pmi8998_charger" which uses the qpnp-smb2 driver, there is also an "smb5"
driver presumably for newer PMICs. This driver is used for the charger block
found on the PMI8998 and PM660 at least, a name like "pmi8998_charger" might be
more suitable.

>
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm PMI8998/PM660 Switch-Mode Battery Charger "2"
>> +
>> +maintainers:
>> + - Caleb Connolly <caleb.connolly@linaro.org>
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - qcom,pmi8998-smb2
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + interrupts:
>> + items:
>> + - description: usb plugin
>
> Just maxItems:1 (description is obvious and matches names).
>
>> +
>> + interrupt-names:
>> + items:
>> + - const: usb-plugin
>> +
>> + io-channels:
>> + items:
>> + - description: USB in current in uA
>> + - description: USB in voltage in uV
>> +
>> + io-channel-names:
>> + items:
>> + - const: usbin_i
>> + - const: usbin_v
>> +
>
> What about monitored-battery? How do you configure the battery
> characteristics?
>
>> +required:
>> + - compatible
>> + - reg
>> + - interrupts
>> + - interrupt-names
>> + - io-channels
>> + - io-channel-names
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/interrupt-controller/irq.h>
>> + pmic {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + #interrupt-cells = <4>;
>> +
>> + smb2@1000 {
>
> Generic node name please, so "charger".
>
>
>
> Best regards,
> Krzysztof

--
Kind Regards,
Caleb (they/them)

\
 
 \ /
  Last update: 2022-04-02 17:52    [W:0.087 / U:0.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site