Messages in this thread Patch in this message |  | | From | Junwen Wu <> | Subject | [PATCH v1] thermal/core: change mm alloc method to avoid kernel warning | Date | Sun, 17 Apr 2022 12:56:01 +0000 |
| |
Very high cooling device max state value makes cooling device stats buffer allocation fails,like below.Using kzvalloc instead of kzalloc can avoid this issue.
[ 7.392644]WARNING: CPU: 7 PID: 1747 at mm/page_alloc.c:5090 __alloc_pages_nodemask+0x1c0/0x3dc [ 7.392989]Call trace: [ 7.392992]__alloc_pages_nodemask+0x1c0/0x3dc [ 7.392995]kmalloc_order+0x54/0x358 [ 7.392997]kmalloc_order_trace+0x34/0x1bc [ 7.393001]__kmalloc+0x5cc/0x9c8 [ 7.393005]thermal_cooling_device_setup_sysfs+0x90/0x218 [ 7.393008]__thermal_cooling_device_register+0x160/0x7a4 [ 7.393012]thermal_of_cooling_device_register+0x14/0x24 [ 7.393140]backlight_cdev_register+0x88/0x100 [msm_drm]
Signed-off-by: Junwen Wu <wudaemon@163.com> --- drivers/thermal/thermal_sysfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/thermal_sysfs.c b/drivers/thermal/thermal_sysfs.c index f154bada2906..361e0d0c241b 100644 --- a/drivers/thermal/thermal_sysfs.c +++ b/drivers/thermal/thermal_sysfs.c @@ -829,7 +829,7 @@ static void cooling_device_stats_setup(struct thermal_cooling_device *cdev) var += sizeof(*stats->time_in_state) * states; var += sizeof(*stats->trans_table) * states * states; - stats = kzalloc(var, GFP_KERNEL); + stats = kvzalloc(var, GFP_KERNEL); if (!stats) return; @@ -848,7 +848,7 @@ static void cooling_device_stats_setup(struct thermal_cooling_device *cdev) static void cooling_device_stats_destroy(struct thermal_cooling_device *cdev) { - kfree(cdev->stats); + kvfree(cdev->stats); cdev->stats = NULL; } -- 2.25.1
|  |